OOD_DOWNLOAD_FILE_MAX does not work in Open OnDemand 4.2.4

Get Help
1

Hi,

I am running Open OnDemand 4.2.4 and was trying to increase the maximum file download size in the Files app.

According to the documentation, I configured:

# /etc/ood/config/apps/dashboard/env
OOD_DOWNLOAD_FILE_MAX=161061273600

However, even after restarting the PUN, the Files app continued to report the default 10 GiB limit:

The file is too large to download.
File downloads should be less than 10737418240 bytes.

I also tried the configuration profile setting:

download_file_max: 161061273600

but this did not have any effect either.

After checking the installed Dashboard source:

grep -nA15 'def int_configs' \
  /var/www/ood/apps/sys/dashboard/config/configuration_singleton.rb

I found:

def int_configs
  {
    :bc_clean_old_dirs_days       => 30,
    :download_dir_timeout_seconds => 5,
    :download_dir_max             => 10_737_418_240,
    :file_editor_max_size         => 12_582_912,
    :file_download_max            => 10_737_418_240,
    :project_size_timeout         => 15,
    :novnc_default_compression    => 6,
    :novnc_default_quality        => 2,
  }.freeze
end

Since the environment variable is generated from the configuration key, it appears that the actual variable is:

OOD_FILE_DOWNLOAD_MAX

rather than:

OOD_DOWNLOAD_FILE_MAX

Similarly, the configuration-profile key appears to be:

file_download_max:

rather than:

download_file_max:

Using:

OOD_FILE_DOWNLOAD_MAX=161061273600

works as expected.

Could you confirm whether this is a documentation issue, or whether the implementation is intended to use download_file_max / OOD_DOWNLOAD_FILE_MAX?

If the current implementation is correct, the documentation may need to be updated to use:

file_download_max
OOD_FILE_DOWNLOAD_MAX

Thanks.

2

Thanks for catching this Emik, it looks like we did mistakenly use the file_download_max key while intending to use download_file_max (to be aligned with download_dir_max). I’ll note for others that this affects all versions > 4.1. Using the other key as a temporary solution will certainly work fine, but keep an eye out for this to be changed to the documented version in an upcoming 4.2 patch. I’ve opened `file_download_max` should be `download_file_max` · Issue #5808 · OSC/ondemand · GitHub to track this, and it should be noted that since the 4.1 release has received its last patch already, this will not be updated there.