tomgreen66
(Thomas Green)
September 7, 2022, 9:35pm
1
Hi,
Just upgraded OnDemand to latest release and spotted that on restart I spotted:
Suggested command:
sudo systemctl try-restart httpd24-httpd.service .service
Restart the ondemand-dex service now.
Suggested command:
sudo systemctl restart ondemand-dex.service
This seemed to look odd (the .service
). Looking at examples in docs it seems it should have had http24-htcacheclean.service
. I looked back in the documentation and cannot see where this should have been enabled or started. I have now started and enabled htcacheclean but now spotted in Github that the code seems to be broken since it was removed from the apache_services
but the print out expects it still. Shall I raise a ticket and also should htcacheclean be used?
travert
(Travis Ravert)
September 8, 2022, 1:59pm
2
Hello! Thanks for the info. What OS are you running?
The htcacheclean
looks like it was used previously but has been removed since earlier this year which can be seen here:
OSC:master
← OSC:ood-portal-generator-deb
opened 09:17PM - 11 May 22 UTC
Fixes #1989
The logic here is if no checksum exists, it's assumed they "match" … which will tell other places in code it's safe to replace.
I'm not actually sure this solves the problem though because the `checksum_exists?` is called before `update_replace?` which is what I think is leading to issue in #1989. @johrstrom If you can replicate in a container, maybe try this change to see if it resolved the issue?
┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1201735133575781/1202263832203038) by [Unito](https://www.unito.io)
So it may just be the output message is incorrect and needs fixed, which I can open an issue for once I find where this is happening.
It sounds like we may need to also open an issue in the docs as well, I do see some mentions in the docs for CentOS 7 related things, could you share the specific page you were looking at?
tomgreen66
(Thomas Green)
September 9, 2022, 10:13am
3
Hi,
Looks like Support Ubuntu 20.04 packages with OnDemand 2.0 (#2141) · OSC/ondemand@835ff77 · GitHub where it updated ondemand/application.rb at ca681fd38d5c19b8e10bb9b80f1d144faccf9b90 · OSC/ondemand · GitHub with
def apache_services
if OodPortalGenerator.scl_apache?
['httpd24-httpd']
else
['httpd']
end
end
but left in reference to index 1. Looks like its fixed on master but just not in 2.0.28 tag.
puts "Completed successfully!"
if changed
puts ""
puts "Restart the #{apache_services[0]} service now."
puts ""
puts "Suggested command:"
puts " sudo systemctl try-restart #{apache_services[0]}.service #{apache_services[1]}.service"
puts ""
end
If you search for htcacheclean
in the documentation you see where its used in the example output so again just confusing - e.g. Search — Open OnDemand 2.0.20 documentation
travert
(Travis Ravert)
September 9, 2022, 1:55pm
4
Thanks for the help and bringing this up. I’ve submitted an issue in the main repo to ensure we take a look at the htcacheclean
service:
opened 02:38PM - 08 Sep 22 UTC
area/tech debt
area/build
We received a discourse over upgrading OOD that lead them to ask some questions … about the `htcacheclean` service in the code which can be seen here:
https://discourse.openondemand.org/t/htcacheclean-usage-and-possible-bug/2270/2
Previously this was adjusted and largely removed it looks like in #2012. The question is now whether there are any distros or reason we need to investigate this service and have it active for; and if so, introduce needed logic to enable and start the service.
┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1202821104799596/1202946646830360) by [Unito](https://www.unito.io)
And similarly I’ve put in an issue with our docs to also make sure mentions of the service are removed to clear up any confusion:
opened 01:53PM - 09 Sep 22 UTC
There are references in the docs right now to `htcacheclean` needing to be ran, … but it looks like this has been removed from the code base and so should also be removed from being mentioned in the docs.
Looks like there are a few mentions:
* https://osc.github.io/ood-documentation/latest/app-development/interactive/setup/enable-reverse-proxy.html?highlight=htcacheclean
* https://osc.github.io/ood-documentation/latest/installation/add-ssl.html?highlight=htcacheclean
* https://osc.github.io/ood-documentation/latest/installation/add-ldap.html?highlight=htcacheclean
The related ticket about this in the ondemand repo is here:
* https://github.com/OSC/ondemand/issues/2273
Which points out the PR where this service was removed.
┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1201735133575781/1202953223233835) by [Unito](https://www.unito.io)
Thanks again for bringing this to our attention!
system
(system)
Closed
March 8, 2023, 1:56pm
5
This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.