OOD myjobs app: safe to rearrange elements within index.html.erb?

Get Help
1

In our dev machine’s myjobs/app/views/workflows/index.html.erb, I’ve swapped the positioning of the “Submit Script” block (the one with the “Open Editor” button) and the “Job Details” block so that the “Open Editor” button is more readily apparent to our novice users, and we all really like this layout change…
Q1: is there any drawback in doing this?

(The only thing I can think of is a javascript using nth-child or something instead of targeting by div#script-details-panel and div#job-details-panel, but it’s probably safer to ask!)

Q2: Assuming that modification is safe, could you remind me if a yum-update would wipe out that change or not?

Q3: Just out of curiosity, why is the “Job Details” section above the “Submit Script” block? In my admittedly naive opinion, it seems like the vast majority of user interaction would take place with SubmitScript and there’s very few reasons to even glance at JobDetails.

As a quick reference, here’s the javascript to rearrange the two “live”, for anyone who’d like to see how it’d look:

document.querySelector('#job-details-container').insertBefore(document.querySelector('#script-details-panel'),document.querySelector('#job-details-panel'))

…just paste that into Chrome’s console, or type it into the url-bar after typing a javascript: prefix.
(note: Chrome won’t allow you to paste in a full javascript:..... line, because security.)

2
  1. I’d have to look at it more deeply to be sure.
  2. A yum update will wipe it.
  3. (I think) The script can be arbitrary length, so putting something below it (if it’s 1000 lines long) would be easy to miss. That’s my off the top, out of thin air guess.

Yea the UX of that app is not straight forward, but I think you’re on the right track; that the details pane should to be moved to give the script pane prominence. But I don’t think swapping them is enough. Maybe hide it and be able to expand it like how we do in active jobs to get more details on that job? So it gets moved the to the table in the middle-left of the screen?

1 Like
3

Ahh, thank you for that! The arbitrary length thing does indeed make a sensible origin story.

I 100% agree with your brainstorming on that, too! I’ll ask around here and get some new users’ perspectives and report back here if it seems worthwhile.

Thanks again!